feat(behavior_path_planner): fix lane change drivable lanes #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportBase: 10.47% // Head: 10.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2324 +/- ##
==========================================
- Coverage 10.47% 10.47% -0.01%
==========================================
Files 1250 1250
Lines 90971 90982 +11
Branches 20916 20923 +7
==========================================
Hits 9532 9532
- Misses 71446 71455 +9
- Partials 9993 9995 +2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Before PRb4_pr.mp4After PRafter_pr.mp4 |
zulfaqar-azmi-t4
approved these changes
Nov 19, 2022
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…foundation#2324) * fix(behavior_path_planner): delete unnecessary codes Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): fix lane change drivable lanes Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…foundation#2324) * fix(behavior_path_planner): delete unnecessary codes Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): fix lane change drivable lanes Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, it cannot generate correct drivable lanes. In this PR, I fixed the issue and checked it does work well.
simplescreenrecorder-2022-11-19_00.55.13.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.